base64 icon indicating copy to clipboard operation
base64 copied to clipboard

Bad performance with Hermes Engine

Open marf opened this issue 4 years ago • 0 comments

Hello, I am using this package in a React Native app. The problem is that while using the Hermes Engine the string concatenation with += is very slow.

With this issue https://github.com/facebook/hermes/issues/111 one of Herme's developers suggested to use output as an array and push elements to it and finally join everything. Can this package be modified to support those kinds of optimizations and be used with the new Hermes Engine?

Thank you

marf avatar Oct 06 '19 11:10 marf