SignacX icon indicating copy to clipboard operation
SignacX copied to clipboard

Seurat v4.3.0 compatibility issue

Open potulabe opened this issue 2 years ago • 1 comments

Hi! Thanks a lot for the SignacX package! I've just encountered a problem, trying to run it with the Seurat v4.3.0, where they had changed column names of a dataframe, returned by the FindMarkers function. So instead of avg_logFC they have avg_log2FC. And because of it the cluster assignment in SignacBoot doesn't work properly.

potulabe avatar Feb 16 '23 16:02 potulabe

The other issue that I've encountered that the code doesn't work if FindMarkers here in SignacBoot returns 0 or 1 marker genes with avg_log2FC < 0. So I wonder if it is by design that you expect for each cluster to have both positive and negative marker genes.

potulabe avatar Feb 16 '23 18:02 potulabe