google-translate-api icon indicating copy to clipboard operation
google-translate-api copied to clipboard

Use JSON.parse instead of safeEval

Open Adam-Clrk opened this issue 6 years ago • 3 comments

use of safeEval is considered a vulnerability

https://nodesecurity.io/advisories/337

Adam-Clrk avatar Jun 23 '18 13:06 Adam-Clrk

Codecov Report

Merging #71 into master will decrease coverage by 0.11%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #71      +/-   ##
=========================================
- Coverage   92.42%   92.3%   -0.12%     
=========================================
  Files           2       2              
  Lines          66      65       -1     
=========================================
- Hits           61      60       -1     
  Misses          5       5
Impacted Files Coverage Δ
index.js 90% <100%> (-0.2%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 777d7db...fd2d322. Read the comment docs.

codecov-io avatar Jun 23 '18 13:06 codecov-io

Coverage Status

Coverage increased (+1.4%) to 92.308% when pulling fd2d32203e7a8d8b35a04a382b2b274603cdce40 on Adam-Clrk:master into 777d7db94f82ec402e7758af1549818c07d55747 on matheuss:master.

coveralls avatar Jun 23 '18 13:06 coveralls

Maybe someone should create a fork of this and keep it updated ?

Done in https://github.com/vitalets/google-translate-api/pull/2.

vitalets avatar Feb 13 '19 14:02 vitalets