mathesar
mathesar copied to clipboard
Parsing date entries on frontend.
Fixes #2327
Technical details
This PR adds an allowPartialParse
flag to the FormattedInput
. This flag prevents strings that are not formatted as they are incomplete. Incomplete date inputs are enabled with a has-error
class that signifies that the input is not ready to be submitted and is in incorrect format.
Only parsed dates are sent to the backend now rather than sending raw user input like before.
Also added few more formatting strings to format special cases.
Screenshots
https://github.com/mathesar-foundation/mathesar/assets/31622972/9c35bc7c-9907-425c-a3c8-8fcaa1de460c
Checklist
- [x] My pull request has a descriptive title (not a vague title like
Update index.md
). - [x] My pull request targets the
develop
branch of the repository - [x] My commit messages follow best practices.
- [x] My code follows the established code style of the repository.
- [ ] I added tests for the changes I made (if applicable).
- [ ] I added or updated documentation (if applicable).
- [x] I tried running the project locally and verified that there are no visible errors.
Developer Certificate of Origin
Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
@pavish I had initially assigned this to me to review since I opened the ticket. But now I see that it's targeting code that you wrote, so I think it would be better if you could review it. I've assigned you.