mathesar icon indicating copy to clipboard operation
mathesar copied to clipboard

Escape key cancel edits and transitions to select mode

Open chidam333 opened this issue 1 year ago • 2 comments

Fixes #1116

Escape key cancels edits and transitions to select mode

Technical details One of the test fails but i am not aware what that test is about i have it below This is what the new changes looks like

https://user-images.githubusercontent.com/86545749/194195126-297f7549-4b21-456b-bd0e-e7a63240bdd6.mp4

Checklist

  • [X] My pull request has a descriptive title (not a vague title like Update index.md).
  • [X] My pull request targets the master branch of the repository
  • [X] My commit messages follow best practices.
  • [X] My code follows the established code style of the repository.
  • [ ] I added tests for the changes I made (if applicable).
  • [ ] I added or updated documentation (if applicable).
  • [ ] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

image

chidam333 avatar Oct 06 '22 01:10 chidam333

Codecov Report

Base: 92.70% // Head: 92.70% // No change to project coverage :thumbsup:

Coverage data is based on head (cc0662a) compared to base (044e512). Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1757   +/-   ##
=======================================
  Coverage   92.70%   92.70%           
=======================================
  Files         144      144           
  Lines        7023     7023           
=======================================
  Hits         6511     6511           
  Misses        512      512           
Flag Coverage Δ
pytest-backend 92.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Oct 11 '22 17:10 codecov-commenter

Great . I will look into this issues and start working on it as soon as I can .

chidam333 avatar Oct 11 '22 18:10 chidam333

I'm closing this PR because it seems to be superseded by #1827

seancolsen avatar Oct 17 '22 14:10 seancolsen