mathesar icon indicating copy to clipboard operation
mathesar copied to clipboard

Provide errors with established error response pattern for queries

Open pavish opened this issue 2 years ago • 1 comments

Description

The queries endpoint does not provide error messages similar to the rest of our code base. It should provide errors in the current established pattern inorder for the frontend to know what to expect.

Related PR: https://github.com/centerofci/mathesar/pull/1589

pavish avatar Sep 19 '22 17:09 pavish

Thanks for making this issue. It's been on the back of my mind for some time now.

mathemancer avatar Sep 20 '22 06:09 mathemancer

Addressed to unkown extent by this PR: https://github.com/centerofci/mathesar/pull/1589

Will play around with frontend to try and find exceptions that break the established response pattern.

dmos62 avatar Oct 19 '22 11:10 dmos62

I've not managed to find noncompliant errors by playing around with the frontend. @pavish @seancolsen could the frontend team report errors that need fixing?

Marking this as blocked until a report comes in.

dmos62 avatar Oct 19 '22 13:10 dmos62

@dmos62 I suggest closing this and opening separate issues for new reports.

kgodey avatar Oct 19 '22 20:10 kgodey