Matthias Hertel comments

Results 41 comments of


                                            Matthias Hertel

Not finding devices on Windows 10

Just an observation: When disabling all WiFi network adapters and using the ethernet only my machine can find devices. Otherwise not.

Use `int pin_mode` instead of `bool pullupActive` in OneButton() constructor.

Please remove unused code. Please also update the documentation (README, CHANGELOG) Any changes in examples required ?

Use `int pin_mode` instead of `bool pullupActive` in OneButton() constructor.

I found another solution for you using the new `setup(...)` function . See #129

ESP::getFlashChipMode crashes on ESP32S3 boards

see also https://github.com/espressif/arduino-esp32/issues/9748

'Reallocating large String(... -> ...)' warning when using WebServer

The output appears also in the published version 3.1.2 when DEBUG_ESP_PORT is enabled even when Debug Level == none. Example: ``` [String] 'Content-Ty ... rigin: * ': Reallocating large String(159...

How to get rid of #define PIN_INPUT?

There is no need to use a OneButton instance as a global variable. You can defer creating this by just having a global pointer and initializing the OneButton instance later....

Press logic not completely right

This is a functional enrichment. Can you provide a implementation for this and create a pull request ?

Press logic not completely right

I see why you need it and your definition of "press" is meaningful but different than the current definition and will be a breaking change therefore. I also to see...

Support manufacturer-specific parameters

That's a great improvement. Thanks a lot. I will test...

getRPM() uses hard coded number of pulses per rotation and ignores LatchMode

@ftjuh : right analysis. Please create a pull request and check with your encoder.