RotaryEncoder icon indicating copy to clipboard operation
RotaryEncoder copied to clipboard

defined(ARDUINO_AVR_NANO_EVERY) not work with Nano

Open stef-ladefense opened this issue 3 years ago • 3 comments

thank for your library, is very good !

i use Nano, and the precompilator "defined(ARDUINO_AVR_NANO_EVERY)" not work for my arduino ide 1.8.13 the correct syntax is "defined(ARDUINO_AVR_NANO)"

  1. in your exemple "AcceleratedRotator" exst 2 .ino strictely identical

best regard,

Stef

stef-ladefense avatar May 01 '21 22:05 stef-ladefense

These are 2 completely different boards with different processors: https://docs.arduino.cc/hardware/nano-every vs. https://docs.arduino.cc/hardware/nano.

mathertel avatar Jul 04 '21 13:07 mathertel

you did not understand what i mean in your examples you use #if defined (ARDUINO_AVR_UNO) || defined (ARDUINO_AVR_NANO_EVERY) the uno and the nano use the same microcontroller instead, we should write #if defined (ARDUINO_AVR_UNO) || defined (ARDUINO_AVR_NANO) || defined (ARDUINO_AVR_NANO_EVERY)

stef-ladefense avatar Jul 04 '21 13:07 stef-ladefense

I see, thanks for explaining - I got you wrong. Can you create a pull request ?

mathertel avatar Jul 05 '21 11:07 mathertel