contentfordevelopers icon indicating copy to clipboard operation
contentfordevelopers copied to clipboard

Refactor SCSS/MUI to TailwindCSS - LeetCode PAGE

Open mathcodes opened this issue 2 years ago • 4 comments

Make sure your changes have the same if not better responsiveness, colors (theme coming so look out for that addition!!!), and general style. Thanks!

mathcodes avatar Jan 26 '23 22:01 mathcodes

Hi @mathcodes, I am Monsef, Somebody took care of it so you could close the issue

ghost avatar Jul 13 '23 16:07 ghost

I can do that, but if you'd like there should be quite a bit fo SCSS and MUI in there to get rid of. Either way, up to you!

-Jon Christie Web Developer, Educator (919) 368-3369 Email @.***> Portfolio https://jonchristie.net

On Thu, Jul 13, 2023 at 12:31 PM Manssif Abdeldjalil Boutebina < @.***> wrote:

Hi @mathcodes https://github.com/mathcodes, I am Monsef, Somebody took care of it so you could close the issue

— Reply to this email directly, view it on GitHub https://github.com/mathcodes/contentfordevelopers/issues/155#issuecomment-1634546850, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIZF44ZAGL7OYHDHDCRPRDXQAPEXANCNFSM6AAAAAAUIAKF3Y . You are receiving this because you were mentioned.Message ID: @.***>

mathcodes avatar Jul 13 '23 16:07 mathcodes

  • [x] remove useless imports
  • [x] remove the /pages/page.css and convert the css margin to a tailwind one
  • [x] rename the pages default exported function with the same name of the component (the names were PageTemplate)
  • [x] clean up the leetcode page' code
  • [x] inhance the /data/images.js way of export images (map instead of array)
  • [x] rename the problemset table to ProblemSetTable.jsx and the components file to ProblemSetTable/index.jsx
  • [x] remove unnecessary tailwind classes in the leetcode page & improve the conditioned tailwind classes
  • [x] using json based data files other than js ones
  • [x] make the scrolling behavior of the table auto

ghost avatar Jul 13 '23 17:07 ghost

I can do that, but if you'd like there should be quite a bit fo SCSS and MUI in there to get rid of. Either way, up to you! -Jon Christie Web Developer, Educator (919) 368-3369 Email @.> Portfolio https://jonchristie.net On Thu, Jul 13, 2023 at 12:31 PM Manssif Abdeldjalil Boutebina < @.> wrote: Hi @mathcodes https://github.com/mathcodes, I am Monsef, Somebody took care of it so you could close the issue — Reply to this email directly, view it on GitHub <#155 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIZF44ZAGL7OYHDHDCRPRDXQAPEXANCNFSM6AAAAAAUIAKF3Y . You are receiving this because you were mentioned.Message ID: @.***>

there is a function called makeTailWindTableVisible in the leetcode page, I tried to understand why is it there but I couldn't ? it gets the DOM element of the div which contains the problems table and add dipslay: block style

ghost avatar Jul 13 '23 17:07 ghost