contentfordevelopers icon indicating copy to clipboard operation
contentfordevelopers copied to clipboard

Refactor SCSS/MUI to TailwindCSS - Homepage Component

Open mathcodes opened this issue 2 years ago • 9 comments

Make sure your changes have the same if not better responsiveness, colors (theme coming so look out for that addition!!!), and general style. Thanks!

mathcodes avatar Jan 26 '23 21:01 mathcodes

Hi @mathcodes, I'd like to work on this

maryojo avatar Apr 23 '23 15:04 maryojo

How is everything going?

mathcodes avatar May 31 '23 19:05 mathcodes

Hi @mathcodes, I'm sorry I didn't give feedback yet. The components I found that had to be refactored were very few and they were mostly components that looked like they had been replaced on the homepage, like the <ContributorSection>. Would it be possible to point out the other parts I may be missing?

maryojo avatar May 31 '23 21:05 maryojo

Sure no problem. I would go into your local repo and search for "Material" and tons of unwanted code will show up. Here is what I got:

image

mathcodes avatar May 31 '23 22:05 mathcodes

Alright, I'll check this out

maryojo avatar Jun 01 '23 09:06 maryojo

I have checked every use of 'material' in the code and I saw that the Material UI components were not being used. About 6 components were defined in the pages - leetcode, hackerrank, codewars, but they were not used image

Also, the ItemCard and Item used the material UI components, but there were no other components that used the ItemCard or Item component image

Am I supposed to still make changes to the ItemCard & Item components?

maryojo avatar Jun 01 '23 19:06 maryojo

Great, way to knock out some spring cleaning!

And yes, we are aiming to keep the same styles, just by using either Tailwind or raw CSS if needed. Let me know if that makes sense or if you'd like some help!

mathcodes avatar Jun 02 '23 16:06 mathcodes

Okay, I should remove unused parts and replace the styling, right?

maryojo avatar Jun 05 '23 20:06 maryojo

Yup. Removing unused for sure, and when replacing with TailwindCSS (the used MUI or SASS), just do your best to keep the end result the same. Thanks! With that said, if you feel like you can improve anything, go right ahead!!! We can always discuss when I review :)

mathcodes avatar Jun 10 '23 14:06 mathcodes