Ayaz Salikhov
Ayaz Salikhov
New images are pushed and ready to use 🎉 https://quay.io/repository/jupyter/pytorch-notebook?tab=tags
@johanna-reiml-hpi thank you for this PR. It's nice to have GPU enabled image at least for pytorch and I think `variant` feature might be used in other circumstances.
That's a nice trick, and I love it! Fortunately, I added testing for `run-hooks` only a couple months ago, so as longs as the tests are ok, we should be...
@yuvipanda I merged the previous PR, please rebase/merge/create new PR for start.sh and run-hooks.py (whichever you choose and makes git diff nice and small is ok for me).
I agree with @yuvipanda on @manics issue. Generally speaking, we haven't promised the order in which shell scripts are sourced/called (the current implementation is in order and tests use this...
@yuvipanda also, when you will be porting `start.sh`, take a look at [`plumbum`](https://plumbum.readthedocs.io/en/latest/). We already use it in this repo for testing and tagging, so it won't increase the number...
Added a test for unset: https://github.com/jupyter/docker-stacks/pull/2022
Added a test for changing variable value: https://github.com/jupyter/docker-stacks/pull/2023
@yuvipanda I added some tests for run-hooks and rewrote the test file a little bit, to make adding new tests easier. I believe these tests will make merging this PR...
@yuvipanda do you have plans to continue working on this? 🙂