ffpyplayer icon indicating copy to clipboard operation
ffpyplayer copied to clipboard

Fix problem with fat libraries on iOS due to duplicated symbols.

Open michele-comitini opened this issue 7 years ago • 2 comments
trafficstars

michele-comitini avatar Nov 18 '18 22:11 michele-comitini

Thanks for the fix, but this seems to break on windows (and possibly other compilers that are not gcc).

matham avatar Nov 19 '18 00:11 matham

It should work on clang and gcc. In any case you wouldn''t want those symbols exposed to the world from the resulting .so.

I am not on Windows but redefinition or ifdef macros could fix compiling.

Il giorno lun 19 nov 2018, 01:27 matham [email protected] ha scritto:

Thanks for the fix, but this seems to break on windows (and possibly other compilers that are not gcc).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/matham/ffpyplayer/pull/54#issuecomment-439740195, or mute the thread https://github.com/notifications/unsubscribe-auth/ABL7XCSFYO42xIJj3cijDhc_CZ5EDgKxks5uwfsHgaJpZM4YoLEV .

Il 19 nov 2018 01:27, "matham" [email protected] ha scritto:

Thanks for the fix, but this seems to break on windows (and possibly other compilers that are not gcc).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/matham/ffpyplayer/pull/54#issuecomment-439740195, or mute the thread https://github.com/notifications/unsubscribe-auth/ABL7XCSFYO42xIJj3cijDhc_CZ5EDgKxks5uwfsHgaJpZM4YoLEV .

michele-comitini avatar Nov 19 '18 04:11 michele-comitini