PINA icon indicating copy to clipboard operation
PINA copied to clipboard

Add layer to perform RBF interpolation in reduced order modeling

Open annaivagnes opened this issue 1 year ago • 1 comments

Added the RBFLayer class in the pina/model/layers folder, and updated tutorial8 with a comparison between POD-RBF and POD-NN approaches in reduced order modeling framework.

annaivagnes avatar Jul 18 '24 15:07 annaivagnes

Fine for me, we can merge @dario-coscia

ndem0 avatar Aug 01 '24 14:08 ndem0

Hi @annaivagnes ! Thanks for the PR updates. I have a minor question: does the layer work correctly on a different device than cpu? Also, it would be great to add pytests for the layer, like in the pod tests. After test addition for me it can also be merged

dario-coscia avatar Aug 03 '24 16:08 dario-coscia

@dario-coscia thanks for the suggestions, I changed RBFLayer into RBFBlock and added some tests. It also works with GPU!

annaivagnes avatar Aug 05 '24 15:08 annaivagnes

Great! Thanks @annaivagnes this addition looks useful🚀🚀 @ndem0 we can merge for me

dario-coscia avatar Aug 06 '24 08:08 dario-coscia