solvable part of CohenCyril's abel backport
Motivation for this change
Extracts the part from https://github.com/math-comp/math-comp/pull/944 that concern solvable (with a few things moved to zmodp).
Depends on:
- https://github.com/math-comp/math-comp/pull/1196
Things done/to do
- [x] added corresponding entries in
CHANGELOG_UNRELEASED.md
- [ ] added corresponding documentation in the headers
- [x] tried to abide by the contribution guide
Compatibility with MathComp 1.X
- [ ] I added the label
TODO: MC-1 portto make sure someone ports this PR to themathcomp-1branch or I already opened an issue or PR (please cross reference).
Automatic note to reviewers
Read this Checklist and put a milestone if possible.
I have just starting reviewing before realizing that actually the code that I was reviewing was already merged :disappointed: Can someone that knows this PR resolve the conflicts. Thanks
I am quite confused, I got rid of the commits for the previous PRs and rebased on top of master, it should be correct now.
Sad, I hoped I could avoid compiling myself...
I don't understand why the CI is happy. Me I get
File "./algebra/zmodp.v", line 396, characters 11-18:
Error: The variable tpermJt was not found in the current environment.
The CI does too, does it not ?
some do, the majority succeeds
Yes, but a lot of them do not need algebra. The ones who do were skipped (as far as I understand).
@Tragicus is it ready for review again (can we undraft?)
Is there something left to do here, beyond rebasing?
@Tragicus if you say you are done I can have a look again
I think so. As an orthogonal matter of fact, I just noticed that we should be able to remove a few more _.+1 once https://github.com/math-comp/math-comp/pull/1256 is merged.
@Tragicus can you resolve the conflicts?
fine with me. @CohenCyril you can merge.