math-comp icon indicating copy to clipboard operation
math-comp copied to clipboard

solvable part of CohenCyril's abel backport

Open Tragicus opened this issue 1 year ago • 7 comments

Motivation for this change

Extracts the part from https://github.com/math-comp/math-comp/pull/944 that concern solvable (with a few things moved to zmodp).

Depends on:

  • https://github.com/math-comp/math-comp/pull/1196
Things done/to do
  • [x] added corresponding entries in CHANGELOG_UNRELEASED.md
  • [ ] added corresponding documentation in the headers
  • [x] tried to abide by the contribution guide
Compatibility with MathComp 1.X
  • [ ] I added the label TODO: MC-1 port to make sure someone ports this PR to the mathcomp-1 branch or I already opened an issue or PR (please cross reference).
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

Tragicus avatar Mar 29 '24 13:03 Tragicus

I have just starting reviewing before realizing that actually the code that I was reviewing was already merged :disappointed: Can someone that knows this PR resolve the conflicts. Thanks

thery avatar Jun 24 '24 13:06 thery

I am quite confused, I got rid of the commits for the previous PRs and rebased on top of master, it should be correct now.

Tragicus avatar Jun 24 '24 13:06 Tragicus

Sad, I hoped I could avoid compiling myself...

Tragicus avatar Jun 24 '24 13:06 Tragicus

I don't understand why the CI is happy. Me I get

File "./algebra/zmodp.v", line 396, characters 11-18:
Error: The variable tpermJt was not found in the current environment.

thery avatar Jun 24 '24 14:06 thery

The CI does too, does it not ?

Tragicus avatar Jun 24 '24 14:06 Tragicus

some do, the majority succeeds

thery avatar Jun 24 '24 14:06 thery

Yes, but a lot of them do not need algebra. The ones who do were skipped (as far as I understand).

Tragicus avatar Jun 24 '24 14:06 Tragicus

@Tragicus is it ready for review again (can we undraft?)

CohenCyril avatar Nov 06 '24 15:11 CohenCyril

Is there something left to do here, beyond rebasing?

Tragicus avatar Jan 24 '25 08:01 Tragicus

@Tragicus if you say you are done I can have a look again

thery avatar Jan 24 '25 09:01 thery

I think so. As an orthogonal matter of fact, I just noticed that we should be able to remove a few more _.+1 once https://github.com/math-comp/math-comp/pull/1256 is merged.

Tragicus avatar Jan 24 '25 09:01 Tragicus

@Tragicus can you resolve the conflicts?

thery avatar Jan 27 '25 09:01 thery

fine with me. @CohenCyril you can merge.

thery avatar Feb 05 '25 13:02 thery