analysis icon indicating copy to clipboard operation
analysis copied to clipboard

change inequality in ereal_{d,}nbhs and {p,n}infty_{d,}nbhs

Open affeldt-aist opened this issue 3 years ago • 3 comments

  • from strict to large
  • also adds a few lemmas to ereal.v

closed #122 @CohenCyril

This is globally getting a bit bigger (only a few proofs are shortened). I have maybe not been careful enough when updating.

affeldt-aist avatar Dec 04 '21 10:12 affeldt-aist

IIRC, the problem with this PR is that it does not bring the expected code size reduction. But there is now code size augmentation (except with one lemma). Since we all seem to agree that large inequalities fell better suited, we can maybe merge this PR for now. What do you think?

affeldt-aist avatar May 14 '22 00:05 affeldt-aist

I think this PR essentially exibits a lack of abstraction. We should actually understand how to make the code smaller, and I think it might not be about changing the def.

CohenCyril avatar May 16 '22 20:05 CohenCyril