analysis icon indicating copy to clipboard operation
analysis copied to clipboard

mulr_rev out of forms.v

Open affeldt-aist opened this issue 1 year ago • 3 comments

Motivation for this change

fixes #1092

mulr_rev had nothing to do in derive.v

Things done/to do
  • [x] added corresponding entries in CHANGELOG_UNRELEASED.md

~~- [] added corresponding documentation in the headers~~

Compatibility with MathComp 2.0
  • [x] I added the label TODO: HB port to make sure someone ports this PR to the hierarchy-builder branch or I already opened an issue or PR (please cross reference).
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

affeldt-aist avatar Dec 21 '23 11:12 affeldt-aist

There is certainly something smarter to do with R^c.

affeldt-aist avatar Jan 01 '24 13:01 affeldt-aist

@CohenCyril Since you thumbs uped the corresponding you may have an interest in this PR. Otherwise, we'll postpone to 1.0.0.

affeldt-aist avatar Jan 17 '24 06:01 affeldt-aist

@CohenCyril Since you thumbs uped the corresponding you may have an interest in this PR. Otherwise, we'll postpone to 1.0.0.

This should ultimately be backported to mathcomp, but there is no emergency here.

CohenCyril avatar Jan 17 '24 10:01 CohenCyril

mulr_rev definition unfolded, as discussed during the last MathComp-Analysis dev meeting.

affeldt-aist avatar Apr 17 '24 10:04 affeldt-aist

Ok, it looks like the HB.instance for the R^c case is of no use in MathComp-Analysis...

affeldt-aist avatar Apr 17 '24 13:04 affeldt-aist

Let's remove it then. Just to be sure, is the revop structure used then?

proux01 avatar Apr 17 '24 13:04 proux01

I check and report asap.

affeldt-aist avatar Apr 17 '24 14:04 affeldt-aist