Matthias Glastra
Matthias Glastra
My last changes fixed the tests. I also renamed block to filter. Which seems to me that it is a much more logical.
It looks like we have a challenge with the linux tracing. It also contains all the env vars in the proc info when used. So the behavior needs to pass...
@ChaosInTheCRD and I had a conversation on Slack about the implementation because there is a 'hidden' use of Environment inside the commandrun attestor. It used to use the `FilterEnvironmentArray` but...
The purpose of the obfuscation is to have a general list of sensitive keys. And they cover the aspect of keys that are matched based on glob. The current that...
> ... are those case sensitive? Yes they are. > Secret and password are already covered right now. But `sshKey` and `passphrase` is missing, if an env variable contains one...
@jkjell do you think we could include this in the next release too?
Thank you for merging these changes. How do we proceed to add this PR that adds the CLI part too? See: https://github.com/in-toto/witness/pull/522
Hi @Keerthi421 thabk you for your contribution. I will do a double check in a bit but it already looks pretty good to me.
This looks great. One request though it to make sure that you cover the DCO (described [here](https://github.com/apps/dco)). Signing your commits is greatly appreciated too.
Hi @Keerthi421 your last commit was signed but did not have a Sign-off. Please use `git commit --amend -sS` and then force push. It is also a good practice normally...