Mateusz Baran

Results 464 comments of Mateusz Baran
trafficstars

Yes, you can just `Ref` all fields. That would still be much better than a dictionary because `NamedTuple` is a type stable collection with very fast lookup.

Sure, you can add a function like `needs_ref(manifold, point)` for determining if `Ref` is needed.

Yes, using `Dict` vs `NamedTuple` is a tradeoff and `NamedTuple` is only going to be faster for very fast to compute objectives and gradients (my guess would be

Do you mean the storage or CostGrad thing?

That doesn't sound particularly encouraging :slightly_frowning_face:

Cool, that's significantly faster.

I wonder if compilation mode affects coverage.

No, these two things are unrelated.

I think the idea would be to also define `identity_element` to manifolds that can have a group structure but I'm not sure it's a good idea anyway.

I don't think we currently have multiple groups structures with different identity elements (Euclidean and GL are topologically different) but in the future we could encounter such case, right.