Mateusz Hołenko

Hi @xerpi, thanks for your contribution. We have an idea that we'd introduce an API to trigger an action without the need to manually handle cancellation in the model. We're...

This is now merged upstream, thanks again.

Hi @thegabriele97, thanks for your contribution. In the meantime we've added support for this model to upstream Renode, please take a look at: https://github.com/renode/renode-infrastructure/blob/master/src/Emulator/Peripherals/Peripherals/MTD/STM32F4_FlashController.cs. I'm closing this PR, but feel...

I've just noticed that we lack the erase functionality in the upstream model - we plan to add it.

Thanks @gilbaruch for your contribution. Renode provides now STM32F4 model with the erase support - see https://github.com/renode/renode-infrastructure/blob/master/src/Emulator/Peripherals/Peripherals/MTD/STM32F4_FlashController.cs, so the proposed changes should not be required anymore. Please open an issue...

Thanks @guentherweber for your contribution! We started merging your changes with the UART model (https://github.com/renode/renode-infrastructure/commit/7bac5583675e8f5b31daa07dd5c76f883e0044fc) and will continue with the rest of models soon.

> I suspected I might be trampling on an important optimization with the timer change or breaking something. Hoping the test cases I added will cover what's needed for the...

@grifcj I merged fixes to `BasicClockSource` and `ComparingTimer` together with your (slightly refactored) tests upstream: 62fa1ef0110d5004f64cb01dae1c684b6426f25e.

> Cool, so it be ok if I rebase on latest master, drop the related commits from PR, and force push the PR branch? That would be great, thanks!

I checked and merged upstream (with cosmetic formatting changes) commits fixing things in CLOCK, PPI and Timer. I also took a look at the ECB model and it seems fine....