openreads
openreads copied to clipboard
[FEATURE_REQUEST] Filter already set tags from tag list
Is your feature request related to a problem? Please describe. When I assign a tag to a book, a list of existing tags is displayed. That list contains tags which have already been assigned to that book. Given that selecting a tag a second time doesn't add it to the book a second time, it is redundant to display it as a choice.
Describe the solution you'd like When assigning tags to a book, remove already assigned tags from the list of all existing tags.
Are you able to handle this @apobrt ?
I can also handle this
Alright, check with @apobrt then.
Right now, when testing on the Android emulator, the tags feature seems to be broken. The addNewTag function throws because the tag is empty.
I'm assuming the expected behaviour would be, that the user can add their own tags?
Here is a short video displaying the problem:
https://github.com/mateusz-bak/openreads-android/assets/41947147/b74033ed-4652-4b8a-a93c-523b65fda2d1
There was a new controller that was overwriting original tags controller. I removed it and now adding tags works, you can rebase. https://github.com/mateusz-bak/openreads-android/pull/430
@th8m0z how is the work going?
Should be done in the next couple of days! @mateusz-bak
Is the issue fixed ?