openreads icon indicating copy to clipboard operation
openreads copied to clipboard

[FEATURE_REQUEST] Filter already set tags from tag list

Open rYR79435 opened this issue 1 year ago • 9 comments

Is your feature request related to a problem? Please describe. When I assign a tag to a book, a list of existing tags is displayed. That list contains tags which have already been assigned to that book. Given that selecting a tag a second time doesn't add it to the book a second time, it is redundant to display it as a choice.

Describe the solution you'd like When assigning tags to a book, remove already assigned tags from the list of all existing tags.

rYR79435 avatar Jan 07 '24 15:01 rYR79435

Are you able to handle this @apobrt ?

mateusz-bak avatar Jan 11 '24 12:01 mateusz-bak

I can also handle this

th8m0z avatar Jan 11 '24 12:01 th8m0z

Alright, check with @apobrt then.

mateusz-bak avatar Jan 11 '24 12:01 mateusz-bak

Right now, when testing on the Android emulator, the tags feature seems to be broken. The addNewTag function throws because the tag is empty.

I'm assuming the expected behaviour would be, that the user can add their own tags?

th8m0z avatar Jan 21 '24 22:01 th8m0z

Here is a short video displaying the problem:

https://github.com/mateusz-bak/openreads-android/assets/41947147/b74033ed-4652-4b8a-a93c-523b65fda2d1

th8m0z avatar Jan 22 '24 16:01 th8m0z

There was a new controller that was overwriting original tags controller. I removed it and now adding tags works, you can rebase. https://github.com/mateusz-bak/openreads-android/pull/430

mateusz-bak avatar Jan 24 '24 04:01 mateusz-bak

@th8m0z how is the work going?

mateusz-bak avatar Feb 13 '24 15:02 mateusz-bak

Should be done in the next couple of days! @mateusz-bak

th8m0z avatar Feb 23 '24 15:02 th8m0z

Is the issue fixed ?

onbreadassist avatar Aug 20 '24 04:08 onbreadassist