maml icon indicating copy to clipboard operation
maml copied to clipboard

what happens when BOWSR selects parameters corresponding to a structure with isolated atoms.

Open CompRhys opened this issue 3 years ago • 2 comments

The pre-trained MEGNet cannot handle materials with atoms that are isolated with 5\AA, when using BOSWR the GP can select such structures as candidates what happens? I cannot find any error handling in the app code presented here for megnet variant

CompRhys avatar Sep 19 '21 15:09 CompRhys

@CompRhys This is a good point. Currently, we just let the optimization fail. The users will need to handle the errors themselves. Would love to see if there are any alternative ideas of how this can be better handled. We do not have the error handling codes for now to avoid unexpected behaviors

chc273 avatar Sep 19 '21 18:09 chc273

I've been toying around with a reimplementation of BOWSR as I want to compare against my Wren model. I am using different black-box optimisation algorithm and using aflow to do the symmetry work meaning total code should be <200 lines so was quite happy with it but then started hitting this failure modes in some of my more complicated test systems. At the moment I am just filling a constant but this is contrary to the GP smoothness assumption so wondered if you already had a solution. I will let you know if I get a good answer.

CompRhys avatar Sep 19 '21 20:09 CompRhys