m3gnet icon indicating copy to clipboard operation
m3gnet copied to clipboard

a suggestion to change predict_structure function name of m3gNet to predict_energy

Open usccolumbia opened this issue 2 years ago • 1 comments

from m3gnet.models import M3GNet m3gnet_e_form = M3GNet.load() m3gnet_e_form.predict_structure(struc)

In the current m3gNet, we call the predict_structure function to calculate energy, which is very confusing. You should really name the function as predict_energy(), instead of predict_structure(), isn't it?

usccolumbia avatar Jan 26 '23 04:01 usccolumbia

Thanks for the feedback. We will certainly make that change but we will do so in the new DGL version that is slated to replace this version. This TF version will be deprecated soon.

shyuep avatar Jan 26 '23 04:01 shyuep