pymatgen
pymatgen copied to clipboard
Install some optional dependencies in CI
Summary
- Install some optional dependencies in CI, to fix #3684.
- Fix patch for
bader_caller(settingPATHto empty is easier than changing thepatchlocation, and serves the same result wherebadercannot be found inPATH)
Installed
boltztrap2: (partial) installable only on Ubuntu and withpip(uvwouldn't work and suggest nonumpyfound when there is)
Unsuccessful
Remaining
graphviz: 186ead525490e5108126f90c381855b721e3e545, install successful, but still get SKIPPED [1] tests/analysis/test_graphs.py:341: graphviz executables not present, maybe need https://github.com/pygraphviz/pygraphviz/issues/11 andneato+fdp- [ ]
critic2: https://aoterodelaroza.github.io/critic2/installation/ - [ ]
OBAlign: should come withopenbabel? - [ ]
vampire: https://vampire.york.ac.uk/download/ - [ ]
x_trans: http://www.icams.de/content/research/software-development/boltztrap/ (Page not found) - [ ]
zeo/pyzeo: http://www.zeoplusplus.org/download.html (last update 2017)
do we want to merge this as partially complete and leave some of the todos for later?
Thanks for asking. I was facing some resistance while trying to install them (maybe that's the reason they're not installed in CI). And what make things worse is that I never use any of these. Some help would be appreciated:
graphvizseems to install just fine but is still skipped in CI for some reason (check the end of log for split 2).boltztrap2is installed in Ubuntu, and revealed one broken unit test
UPDATE: boltztrap2 installation doesn't look quite reliable for some reason? It used to work just fine, but currently show some installation errors. We would have to drop it if so.
@janosh Perhaps we could merge this as partially finished (as you suggested) and I would work towards the remaining parts shortly. The CI test failure is reported in #3969 and would be fixed by #3972, thanks!
Regarding the installation of BolzTraP2 on Windows, I'm afraid it wouldn't be an easy fix owing to the difference in cmake behavior. Let's install it on Linux only for now until we have a solution.
I would look into why uv failed to install it on Linux later.