pymatgen icon indicating copy to clipboard operation
pymatgen copied to clipboard

Install some optional dependencies in CI

Open DanielYang59 opened this issue 1 year ago • 2 comments

Summary

  • Install some optional dependencies in CI, to fix #3684.
  • Fix patch for bader_caller (setting PATH to empty is easier than changing the patch location, and serves the same result where bader cannot be found in PATH)

Installed

  • boltztrap2: (partial) installable only on Ubuntu and with pip (uv wouldn't work and suggest no numpy found when there is)

Unsuccessful

Remaining

  • graphviz: 186ead525490e5108126f90c381855b721e3e545, install successful, but still get SKIPPED [1] tests/analysis/test_graphs.py:341: graphviz executables not present, maybe need https://github.com/pygraphviz/pygraphviz/issues/11 and neato + fdp
  • [ ] critic2: https://aoterodelaroza.github.io/critic2/installation/
  • [ ] OBAlign: should come with openbabel?
  • [ ] vampire: https://vampire.york.ac.uk/download/
  • [ ] x_trans: http://www.icams.de/content/research/software-development/boltztrap/ (Page not found)
  • [ ] zeo/pyzeo: http://www.zeoplusplus.org/download.html (last update 2017)

DanielYang59 avatar Apr 26 '24 02:04 DanielYang59

do we want to merge this as partially complete and leave some of the todos for later?

janosh avatar May 07 '24 12:05 janosh

Thanks for asking. I was facing some resistance while trying to install them (maybe that's the reason they're not installed in CI). And what make things worse is that I never use any of these. Some help would be appreciated:

UPDATE: boltztrap2 installation doesn't look quite reliable for some reason? It used to work just fine, but currently show some installation errors. We would have to drop it if so.

DanielYang59 avatar May 07 '24 13:05 DanielYang59

@janosh Perhaps we could merge this as partially finished (as you suggested) and I would work towards the remaining parts shortly. The CI test failure is reported in #3969 and would be fixed by #3972, thanks!

DanielYang59 avatar Aug 05 '24 10:08 DanielYang59

Regarding the installation of BolzTraP2 on Windows, I'm afraid it wouldn't be an easy fix owing to the difference in cmake behavior. Let's install it on Linux only for now until we have a solution.

I would look into why uv failed to install it on Linux later.

DanielYang59 avatar Aug 06 '24 14:08 DanielYang59