[Bug]: `converged_ionic` does not account for stopped calculation

[R1j1t]

Email (Optional)

No response

Version

v2023.6.28

Which OS(es) are you using?

• [ ] MacOS
• [ ] Windows
• [X] Linux

What happened?

I have a long VASP calculation and I use STOPCAR to stop the calculation early before reaching wall time limit. Once the vasp finishes, I use the pymatgen.io.vasp.outputs.Vasprun to parse the vasprun.xml and check if the calculations converged based on that I make a decision to resubmit the calculation or not.

However, converged_ionic logic checks if the calculations reached the specified NSW steps and not respects the EDIFFG criteria.: https://github.com/materialsproject/pymatgen/blob/f4e605776b7afc6e74bd6e855f94280268aeb698/pymatgen/io/vasp/outputs.py#L619-L626

So, for my case because the calculation will be stopped early and ionic steps < specified NSW steps, the converged_ionic is always True. Is there something I am missing or is it the desired behavior?

Code snippet

vasprun = Vasprun(vasprun_path, parse_dos=False, parse_eigen=False)
if vasprun.converged:
    return # resubmission not required
else:
    # resubmit calculation

Log output

No response

Code of Conduct

• [X] I agree to follow this project's Code of Conduct