pymatgen icon indicating copy to clipboard operation
pymatgen copied to clipboard

Finish Wyckoff functionality in cif parsing/writing

Open kyledmiller opened this issue 3 years ago • 5 comments

Is your feature request related to a problem? Please describe. I would like to use Pymatgen's wonderful structure manipulation functionality but cif parsing/manipulating/rewriting pipeline in Pymatgen doesn't preserve the wyckoff letters and multiplicities. I see in the code that it's planned for implementation in site_properties, that would be great.

Describe the solution you'd like Parse wyckoff letters and multiplicities from cifs and write them to cifs.

kyledmiller avatar Dec 09 '21 01:12 kyledmiller

You can use the SpaceGroupAnalyzer.get_symmetrized_structure to get the Wyckoff symbols.

shyuep avatar Dec 09 '21 22:12 shyuep

I think this issue is more about propagating metadata already existing in the CIF, i.e. for Wyckoff symbols that have already been annotated, these could be parsed as site properties.

mkhorton avatar Dec 12 '21 19:12 mkhorton

Yes, indeed the get_symmetrized structure works well if I want to find the Wyckoff symbols using spglib but as @mkhorton suggested, I desire to propagate existing metadata in CIFs produced by AFLOW's prototypying code.

kyledmiller avatar Dec 13 '21 16:12 kyledmiller

As far as I know, that information is not parsed today. But if someone wants to take a crack at it, I am happy to include it.

shyuep avatar Dec 13 '21 16:12 shyuep

Sounds good. I might try my hand in the coming months.

kyledmiller avatar Dec 14 '21 17:12 kyledmiller