mp-react-components icon indicating copy to clipboard operation
mp-react-components copied to clipboard

Published 20 hours ago • verified publisher icon materialsproject

Tidy, update, and document Crystal Toolkit scene generation code

Open mkhorton opened this issue 1 year ago • 1 comments

There are a few new features in Crystal Toolkit I'd like to implement, but I noticed the corresponding JavaScript code hadn't been updated in a while and thought some early spring cleaning might help :)

Creating this PR in draft until it's ready to merge, but includes:

  • [x] Updating three.js from 0.139 to 0.160
  • [x] Updating parcel (build tool) and some small updates to make sure code still builds with latest version
  • [x] Remove ColladaExporter, deprecated in favor of GLTF/GLB which are actively maintained and more recent standards
  • [x] Types and documents SceneSettings to make it easier to see what is configurable
  • [ ] Adding docstrings to key functions
  • [ ] Renaming/moving some files for better organization
  • [ ] Fix bug related to GLB export
  • [ ] Fix bug related to objectJson.origin

mkhorton avatar Dec 31 '23 23:12 mkhorton