jobflow icon indicating copy to clipboard operation
jobflow copied to clipboard

`importorskip` statements should be used in the test suite

Open Andrew-S-Rosen opened this issue 2 years ago • 1 comments

If fireworks or matplotlib (potentially others like maggma, moto, ...) are not installed, the test suite fails. It would be better to use a importorskip marker (preferable) or to update the dev optional dependencies to be the full suite of dependencies needed to run the tests. Alternatively, the contributing instructions should say to install the strict dependencies.

Andrew-S-Rosen avatar Sep 28 '23 05:09 Andrew-S-Rosen

I would be happy to accept a PR that skips tests if the packages aren't installed.

utf avatar Sep 28 '23 09:09 utf