fireworks icon indicating copy to clipboard operation
fireworks copied to clipboard

use blueprint for lpad gui

Open tschaume opened this issue 4 years ago • 4 comments

Converting lauchpad GUI to a Flask Blueprint to allow for it to be mounted at a different prefix/application root @mkhorton @shreddd

tschaume avatar Jan 05 '22 23:01 tschaume

Thanks @tschaume. Can I confirm that, to your knowledge, there are no breaking changes in this PR?

@computron This PR is to allow us to more easily deploy FW dashboards for multiple people on NERSC infrastructure but should otherwise not affect dashboards for regular users.

mkhorton avatar Jan 05 '22 23:01 mkhorton

@mkhorton There shouldn't be breaking changes but the commented-out part in fireworks/scripts/lpad_run.py needs to be tested.

tschaume avatar Jan 05 '22 23:01 tschaume

@mkhorton @tschaume I'm trying to catch up on some PRs - could you let me know the current status of this? It looks like some tests are failing but maybe they just need a quick rerun or check

computron avatar Feb 01 '22 23:02 computron

@shreddd and @mkhorton have used the blueprint successfully already I think. Based on what's in this PR, this part needs reimplementation to work with blueprints.

tschaume avatar Feb 01 '22 23:02 tschaume