fireworks icon indicating copy to clipboard operation
fireworks copied to clipboard

Consider switching FWSerializable to monty serialization

Open computron opened this issue 6 years ago • 2 comments

FWSerializable was written before there was a robust serialization package in monty. Now that the latter contains an officially supported serialization package, consider switching FWSerializable to monty serialization.

Or at least make FWSerializable a subclass of monty's serialization if possible.

Will help consistency with monty and other codes we develop.

computron avatar May 25 '18 16:05 computron

This is something I'm considering implementing.

One thing we will lose is the class redirection available with FWSerializeable. Is that ok?

shyamd avatar Mar 06 '19 03:03 shyamd

I think the class redirection is actually pretty important - we do move things around from time to time and FireWorks workflows are intended to be pretty "permanent".

https://groups.google.com/forum/#!searchin/fireworkflows/FW_NAME_UPDATES|sort:date/fireworkflows/ENbXaxdMRBU/0kZvZAJABQAJ

It might be easier to have FWSerializable subclass MSONable?

computron avatar Mar 06 '19 19:03 computron