AliasingErrorHandler checks for 'brmix'

Open xivh opened this issue 2 years ago • 3 comments

The AliasingErrorHandler checks for a 'brmix' error, but this error is not in the error_msgs dictionary.

https://github.com/materialsproject/custodian/blob/202b941ab9c5d8fc3b9b9e5bb26a9e280ba1e0ea/custodian/vasp/handlers.py#L789C30-L789C30

Jul 12 '23 19:07 xivh

@xivh: Thanks for reporting, but isn't it found here?

https://github.com/materialsproject/custodian/blob/202b941ab9c5d8fc3b9b9e5bb26a9e280ba1e0ea/custodian/vasp/handlers.py#L73

Jul 12 '23 21:07 Andrew-S-Rosen

I'm not sure because I haven't used the AliasingErrorHandler before, but I didn't see a way for it to get the status of the VaspErrorHandler. The line you linked is from the VaspErrorHandler's error_msgs.

Jul 12 '23 22:07 xivh

Ah, I believe you're correct.

Jul 12 '23 22:07 Andrew-S-Rosen