atomate2
atomate2 copied to clipboard
[WIP] Input set tutorial
Summary
This is a first draft of additional documentation for the InputSets/Generators in atomate2.
@utf It would be great if you can give me some feedback whether this is the direction you had in mind.
Also there is of course documentation of input sets already in various places that I link to. The question is to what extent we want to "double" the documentation. This mostly concerns the first half of what I wrote e.g. the basic introduction of InputFiles/Sets/Generators already mostly exists in pymatgen and a few paragraphs exist in the workflow tutorial. One sentence I just copied over for now. (While generally the input classes are supposed to be part of
pymatgenduring development it is recommended to include them in
atomate2at first to facilitate rapid iteration. Once mature, they can be moved to
pymatgenor to a
pymatgen` addon package.)
For now I am also mixing information for developers and users in one document. It might be possible to separate this but of course this would mean doubling some more information (e.g. I could separate out developer information and add it to the workflow tutorial.
Two additional questions that popped up when I was looking at the different InputSets/Generators:
Vasp input files do not seem to be inheriting from InputFile. e.g. class Poscar(MSONable)
, class Incar(dict, MSONable)
etc... Any specific reason for this that I should discuss or is this just for historic reasons?
A bit random: What is the previous_input
doing in _get_input
in the cp2k input sets/base.py. I don't see that it is used anywhere? https://github.com/materialsproject/atomate2/blob/33d747adfda16089d6794019828e3988c6a27a6e/src/atomate2/cp2k/sets/base.py#L326C1-L334C46
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 76.51%. Comparing base (
9f64381
) to head (6f741cb
). Report is 4 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #780 +/- ##
==========================================
- Coverage 76.64% 76.51% -0.13%
==========================================
Files 114 114
Lines 8506 8506
Branches 1275 1275
==========================================
- Hits 6519 6508 -11
- Misses 1600 1612 +12
+ Partials 387 386 -1
@utf Just a reminder to take a look if you find the time. So I know whether this is going in the direction intended.
Hi @JonathanSchmidt1, thanks very much for this. This looks perfect to me. They tutorial will need to be updated based on #854 (the input sets have moved there and some of the syntax has changed very slightly). But once that's done I would be happy to merge.
Thank you for taking a look @utf . I will take care of it next week.
the error should be unrelated to this PR
If you fix the torch data version similar to #940 , it should work
@utf if you are happy with the corrections it should be ready to merge
@utf reminder
Thanks @JonathanSchmidt1