atomate2 icon indicating copy to clipboard operation
atomate2 copied to clipboard

[WIP] Defects CP2K

Open nwinner opened this issue 1 year ago • 1 comments

WIP for my defects module.

The jobs/flows could be deleted if @jmmshn 's module moves into common. The builder for assimilating after the fact could be adjusted and added to common as well. To my knowledge there is no equivalent in VASP module. Its not totally code agnostic at the moment though.

nwinner avatar Mar 27 '23 00:03 nwinner

Hi @nwinner, the flow is already in common. The parts that should be language agnostic have been left as abstract methods.

I also added a tutorial on dealing with DFT-code agnostic workflows here: https://github.com/materialsproject/jobflow/blob/main/docs/tutorials/4-generalized-makers.ipynb

Maybe you can just do a PR for driving the CP2K defect calculations only and we can figure out the schema later after a bit of discussion. In short, I really think the workflow should only take you as far as the DefectEntry creation and Freysoldt correction. The final chempot stuff should be left to builders.

jmmshn avatar Mar 27 '23 01:03 jmmshn