material-shell icon indicating copy to clipboard operation
material-shell copied to clipboard

Gnome 46 compatibility

Open ajwild opened this issue 1 year ago • 6 comments

Issue: https://github.com/material-shell/material-shell/issues/991

Documentation used for the upgrade: https://gjs.guide/extensions/upgrading/gnome-shell-46.html https://mutter.gnome.org/cogl/struct.Color.html

The Shell.BlurEffect should change from using sigma to radius, but this requires an update to the TypeScript definitions and I haven't looked into that yet.

There are a couple of references to Clutter.Container which will probably need replacing.

There are some further details in the GJS upgrade guide regarding the following which may be relevant, but I haven't had time to look into it yet:

  • DateMenu.MessagesIndicator
  • MessageTray
  • PopupMenu

This is my first look at a Gnome extension's source code, so if I've done anything wrong or need to do any additional steps then just let me know. At the moment this PR gets the extension running again for me. I have not tested much of the functionality yet, and I do not know if it is backwards compatible with v45.

To give this a test you can follow the manual installation notes and switch to this branch.

ajwild avatar May 18 '24 14:05 ajwild

I'm testing right now, looks perfect in Manjaro running Gnome 46

sytabaresa avatar May 18 '24 22:05 sytabaresa

Gnome 46 is not working with this release(at least for me), but after upgrading to Gnome46 I was able to run it.

piotron avatar May 24 '24 17:05 piotron

Thanks for the patch <3

thenoid avatar May 25 '24 16:05 thenoid

It works, can confirm it = ) Thank you!

Neftedollar avatar Jun 22 '24 13:06 Neftedollar

Working nicely in Manjaro with Gnome 46

leandrolanzieri avatar Jun 28 '24 07:06 leandrolanzieri

Tested on Fedora WS with Gnome46. Works great! Thank you for the patch. Hope it'll be merged soon.

max-kazak avatar Jun 29 '24 04:06 max-kazak

Thanks @ajwild for the PR and everyone for testing. Sorry for the delay I'm currently hard working on Veshell

PapyElGringo avatar Jul 22 '24 08:07 PapyElGringo

@PapyElGringo any idea when it would be available on extensions.gnome.org?

weirdan avatar Jul 24 '24 21:07 weirdan

@weirdan Arf that's would require me to plan an release on extensions.gnome.org and with my current limited time and focus I'm not sure to do it

PapyElGringo avatar Jul 24 '24 21:07 PapyElGringo