material-shell icon indicating copy to clipboard operation
material-shell copied to clipboard

show application launcher

Open ragnarokxg opened this issue 3 years ago • 14 comments

ragnarokxg avatar May 08 '22 09:05 ragnarokxg

#730 #770

ragnarokxg avatar May 09 '22 06:05 ragnarokxg

addition-to-mycollection-more-collection

rwjack avatar May 11 '22 11:05 rwjack

Something seems to be bugged, it's like some callback is recreating the app menu. Check the video below:

https://user-images.githubusercontent.com/59068073/167892289-d8c77e53-841e-4398-829d-d060e0d98b03.mp4

rwjack avatar May 11 '22 15:05 rwjack

Watched the video and did not really see anything. I have been using this code for a little over a month testing before submitting a request and all has worked well.

On Wed, May 11, 2022 at 9:47 AM rwjack @.***> wrote:

Something seems to be bugged, it's like some callback is recreating the app menu. Check the video below:

https://user-images.githubusercontent.com/59068073/167892289-d8c77e53-841e-4398-829d-d060e0d98b03.mp4

— Reply to this email directly, view it on GitHub https://github.com/material-shell/material-shell/pull/796#issuecomment-1123951259, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTXASZCQJEV3DYSKMYOA2DVJPJBJANCNFSM5VLWHLYA . You are receiving this because you authored the thread.Message ID: @.***>

-- Regards; Arnold J. Sandoval m: 505.920.9837

ragnarokxg avatar May 11 '22 23:05 ragnarokxg

I mean I don't understand what you are trying to say, that I modified your code on purpose to make it not work?

Obviously there is some sort of bug that is generated upon executing the following procedure:

  • Close all windows
  • Open any app
  • Go to next workspace
  • You can see the application launcher without the black background

Perhaps I miss-understood your PR? Isn't it supposed to completely disable the application menu?

rwjack avatar May 12 '22 10:05 rwjack

Yes it is. The video you linked did not show that. I will attempt to recreate this bug.

Arnold J Sandoval m: 505.920.9837

On Thu, May 12, 2022, 4:55 AM rwjack @.***> wrote:

I mean I don't understand what you are trying to say, that I modified your code on purpose to make it not work?

Obviously there is some sort of bug that is generated upon executing the following procedure:

  • Close all windows
  • Open any app
  • Go to next workspace
  • You can see the application launcher without the black background

Perhaps I miss-understood your PR? Isn't it supposed to completely disable the application menu?

— Reply to this email directly, view it on GitHub https://github.com/material-shell/material-shell/pull/796#issuecomment-1124847998, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTXAS2EQONX74QFARTNEHLVJTPQVANCNFSM5VLWHLYA . You are receiving this because you authored the thread.Message ID: @.***>

ragnarokxg avatar May 12 '22 13:05 ragnarokxg

I was able to recreate the bug, and I was able to fix it. You can download the newest change and it should work now.

On Thu, May 12, 2022 at 7:20 AM AJ Sandoval @.***> wrote:

Yes it is. The video you linked did not show that. I will attempt to recreate this bug.

Arnold J Sandoval m: 505.920.9837

On Thu, May 12, 2022, 4:55 AM rwjack @.***> wrote:

I mean I don't understand what you are trying to say, that I modified your code on purpose to make it not work?

Obviously there is some sort of bug that is generated upon executing the following procedure:

  • Close all windows
  • Open any app
  • Go to next workspace
  • You can see the application launcher without the black background

Perhaps I miss-understood your PR? Isn't it supposed to completely disable the application menu?

— Reply to this email directly, view it on GitHub https://github.com/material-shell/material-shell/pull/796#issuecomment-1124847998, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTXAS2EQONX74QFARTNEHLVJTPQVANCNFSM5VLWHLYA . You are receiving this because you authored the thread.Message ID: @.***>

-- Regards; Arnold J. Sandoval m: 505.920.9837

ragnarokxg avatar May 12 '22 15:05 ragnarokxg

Absolute Legend.

Working as intended now

rwjack avatar May 12 '22 17:05 rwjack

Glad to hear it! Thank you for your feedback.

Arnold J Sandoval m: 505.920.9837

On Thu, May 12, 2022, 11:06 AM rwjack @.***> wrote:

Absolute Legend.

Working as intended now

— Reply to this email directly, view it on GitHub https://github.com/material-shell/material-shell/pull/796#issuecomment-1125228947, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTXASZ74FL75OP2YCSJTULVJU277ANCNFSM5VLWHLYA . You are receiving this because you authored the thread.Message ID: @.***>

ragnarokxg avatar May 12 '22 18:05 ragnarokxg

This is so needed thing, thank you so much

Meister1593 avatar May 13 '22 21:05 Meister1593

This is especially useful when linting (from other monitor) goes onto another monitor from light background, but monitor with background is pretty much pitch black because of application launcher

Meister1593 avatar May 13 '22 21:05 Meister1593

Would it also be possible to remove the app menu "+" window from the top taskbar when the bool switch is flipped off? It's fairly pointless now that the app menu has been disabled.

https://user-images.githubusercontent.com/59068073/169693255-7cb54f4f-dbab-4ebe-adc8-6262fc02842c.mp4

rwjack avatar May 22 '22 11:05 rwjack

Would it also be possible to remove the app menu "+" window from the top taskbar when the bool switch is flipped off? It's fairly pointless now that the app menu has been disabled. Screencast.from.05-22-2022.01.30.07.PM.1.mp4

Maybe also making icons of categories (not apps) appear instead of just + on workspaces when no apps are running on that workspace? image

Meister1593 avatar May 22 '22 11:05 Meister1593

Not sure about the app icon, but there is another fork that has a pull request that removed the + from the top bar.

Arnold J Sandoval m: 505.920.9837

On Sun, May 22, 2022, 5:43 AM PLYSHKA @.***> wrote:

Would it also be possible to remove the app menu "+" window from the top taskbar when the bool switch is flipped off? It's fairly pointless now that the app menu has been disabled. Screencast.from.05-22-2022.01.30.07.PM.1.mp4

Maybe also making icons of categories (not apps) appear instead of just + on workspaces when no apps are running on that workspace? [image: image] https://user-images.githubusercontent.com/7141787/169693365-f9f68fa2-8e00-4afa-9e82-c671f65a1e7a.png

— Reply to this email directly, view it on GitHub https://github.com/material-shell/material-shell/pull/796#issuecomment-1133877036, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTXAS36QPJKZPGGXRGBFL3VLIMUXANCNFSM5VLWHLYA . You are receiving this because you authored the thread.Message ID: @.***>

ragnarokxg avatar May 22 '22 15:05 ragnarokxg