material-components-flutter-adaptive icon indicating copy to clipboard operation
material-components-flutter-adaptive copied to clipboard

Better adaptaion of Material Design

Open MahMoos opened this issue 3 years ago • 1 comments

Disclaimer: you may find some of the changes here opinionated, but I find them necessary to give more flexibility in usage.

  • Add path property to AdaptiveScaffoldDestination for simpler usage with routing.
  • Add AdaptiveNavigationScaffold.of(context) method to provide its state to descendants.
  • Add appBarBuilder to build different AppBars depending on NavigationType.
  • Add navigationRailTrailing and permanentDrawerFooter.
  • Make the drawer scrollable (closes #35).
  • FAB now can be inside permanentDrawer and is controlled by fabInPermanentDrawer property.
  • Add railDestinationsOverflow property.
  • Add showVerticalDivider to make the VerticalDivider between body and NavigationRail/permanentDrawer optional (closes #56).
  • Menu/Back button is now moved inside NavigationRail from the AppBar to be perfectly aligned with NavigationRailDestinations (closes #2).
  • Make floatingActionButton type Widget not FloatingActionButton as it is in the Scaffold (closes #44).
  • Add AdaptiveFloatingActionButton. This widget should be used to have an expanded FAB inside the permanent drawer.
  • Update examples, and use Material 3 theming.
  • Update dependencies (close #55).

MahMoos avatar Sep 12 '22 13:09 MahMoos

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Sep 12 '22 13:09 google-cla[bot]

Thank you for your contribution. I'm really glad you're excited about Flutter! Unfortunately your patch does not currently meet our quality bar because it makes too many unrelated changes, and is missing CHANGELOG entries.

I suggest breaking this up in 2-3 PRs, separating adding functionality from breaking changes like replacing functionality. Please don't hesitate to submit a new PR at https://github.com/material-foundation/flutter-packages if you have the time. Thanks!

guidezpl avatar Feb 02 '23 09:02 guidezpl