material-web icon indicating copy to clipboard operation
material-web copied to clipboard

fix: buttons' appearance in disabled fieldset

Open datvm opened this issue 1 year ago • 3 comments

Fix #5562

image

datvm avatar Apr 03 '24 11:04 datvm

One change that is different compared to the others is:

.outlined:disabled .icon
// to
:host(:disabled) .outlined .icon {

Because the button inside the shadow root is not actually disabled. I don't think this should affect anything else.

datvm avatar Apr 03 '24 11:04 datvm

A second commit also fixes other controls: Checkbox, Radio, Select, Slider and Switch.

image

Now this standalone commit does not help much as it doesn't fix the issue with #5409 but this commit prepares for when we fix that one. Right now the only way to test it is to put them in a disabled fieldset and then manually set their disabled to false (which means the fieldset is still disabled but each individual component is not).

datvm avatar Apr 03 '24 12:04 datvm

Thanks for this PR, I agree with your approach! There's a couple changes I'd like to make, so I'm going to import this directly for those to get it landed faster.

No action needed from you! Just don't push any more commits to this PR :)

asyncliz avatar Apr 03 '24 17:04 asyncliz