material-web icon indicating copy to clipboard operation
material-web copied to clipboard

Published 20 hours ago • verified publisher icon material-components

Add button type property in mwc-button

Open jpnathan opened this issue 6 years ago • 9 comments

Issue: Button type submit #205

jpnathan avatar Oct 08 '19 01:10 jpnathan

Related to #289

dfreedm avatar Nov 07 '19 22:11 dfreedm

Related to #289

@dfreedm I know that is related to the form submit ticket, but why should that block adding this feature?

fernandopasik avatar Apr 11 '20 23:04 fernandopasik

What does adding this feature without custom element form submission accomplish?

An <mwc-button type="submit"> inside a <form> element will not submit it. I'd be cautious about adding type="submit" which could imply to users that form submission works when it doesn't.

asyncliz avatar Jul 01 '20 18:07 asyncliz

Makes sense @asyncLiz, thanks. We'll need to wait on the result of #289

fernandopasik avatar Jul 01 '20 18:07 fernandopasik

Closing as obsolete

asyncliz avatar Mar 23 '22 18:03 asyncliz

The type attribute wasn't added to button? Is it resolved in some other way?

fernandopasik avatar Mar 23 '22 23:03 fernandopasik

Sorry about that! Was going through and cleaning up a lot of old issues :)

asyncliz avatar Mar 24 '22 21:03 asyncliz

would it make sense to rebase this PR and try to get it ready to merge?

fernandopasik avatar Mar 24 '22 21:03 fernandopasik

would it make sense to rebase this PR and try to get it ready to merge?

If you can rebase it for MWC (skip M3), I'll review it :)

asyncliz avatar Mar 25 '22 18:03 asyncliz

Obsolete with M3. See https://github.com/material-components/material-web/issues/3941 for upcoming support

asyncliz avatar Apr 24 '23 21:04 asyncliz