Add tooltips to Tab Bar

[ravichdev]

Issue by jwold Monday May 25, 2020 at 16:16 GMT Originally opened as https://github.com/xwp/material-design-wp-plugin/issues/258

---

Feature description

---

There are times when the tab bar headings can be set without labels. In this scenario an icon is added without a label. We should ensure that the icon can be given a tooltip.

Acceptance criteria

1. Handle this however we handle the Icon Button block.

• Add a new label input field into the block sidebar.
• Allow the new field to be visible regardless of whether there is a heading on the tab or not.

Note: Similar to #224 where we could add a field in the block sidebar settings to add a tooltip.

Implementation brief

QA testing instructions

Demo

Changelog entry

[ravichdev]

Comment by jwold Friday Jul 03, 2020 at 14:53 GMT

---

We recognize that this is not necessarily ideal because you could have a tooltip that is the same as the label. But for now this seems like an ok solution to ship with.

cc @jbingham and @yasmineevjen

[ravichdev]

Comment by jwold Friday Sep 25, 2020 at 19:31 GMT

---

Closing for now, goes against guidance.

[ravichdev]

Comment by jauyong Thursday Dec 10, 2020 at 19:27 GMT

---

Handle this however we handle the Icon Button block.

[ravichdev]

Comment by jauyong Wednesday Dec 16, 2020 at 19:07 GMT

---

@jwold I've added a Tab block with no label but I don't see an icon being added. Can you confirm the issue? https://dev-mdc-web.pantheonsite.io/wp-admin/post.php?post=1909&action=edit

Editor:

Front end:

[ravichdev]

Comment by jwold Thursday Jan 14, 2021 at 20:57 GMT

---

@jauyong I think the issue is ready for engineering, but recorded a quick video to make sure.

Video: https://v.usetapes.com/fvY0cE215T