material-components-web
material-components-web copied to clipboard
fix(icon-button): Fix position when used as TextFieldIcon
Fixes #4059
This PR fixes the position issue that occurs when an IconButton is used as a TextFieldIcon. It does so by adding negative margin equal to the padding to the IconButton in this particular situation.
I’m closing this pull request for now because of inactivity.
@sdomenet we can always reopen it though! :)
If you need any help, please feel free to open a GitHub issue.
I would like to submit another commit to solve that issue, can I do that here or should I create a new PR?
Please commit to same PR. Thanks!
Codecov Report
Merging #4575 into master will increase coverage by
0.3%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #4575 +/- ##
=========================================
+ Coverage 98.96% 99.26% +0.3%
=========================================
Files 129 129
Lines 6294 6294
Branches 821 821
=========================================
+ Hits 6229 6248 +19
+ Misses 64 45 -19
Partials 1 1
Impacted Files | Coverage Δ | |
---|---|---|
packages/mdc-textfield/foundation.ts | 100% <0%> (ø) |
:arrow_up: |
packages/mdc-checkbox/component.ts | 96.84% <0%> (+1.05%) |
:arrow_up: |
packages/mdc-tab/component.ts | 98.36% <0%> (+3.27%) |
:arrow_up: |
packages/mdc-base/component.ts | 100% <0%> (+3.57%) |
:arrow_up: |
packages/mdc-ripple/component.ts | 100% <0%> (+3.84%) |
:arrow_up: |
packages/mdc-ripple/util.ts | 98% <0%> (+4%) |
:arrow_up: |
packages/mdc-auto-init/index.ts | 100% <0%> (+4.54%) |
:arrow_up: |
packages/mdc-tabs/tab/component.ts | 100% <0%> (+5%) |
:arrow_up: |
packages/mdc-switch/component.ts | 98.24% <0%> (+7.01%) |
:arrow_up: |
packages/mdc-radio/component.ts | 95.74% <0%> (+8.51%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 252009f...d15c732. Read the comment docs.
can we solve PR?