material-components-web
material-components-web copied to clipboard
Banner (incomplete)
HTML and CSS for banner.
Is it OK or, please, point what should be corrected?
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
Codecov Report
Merging #4359 into master will increase coverage by
0.32%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #4359 +/- ##
=========================================
+ Coverage 98.58% 98.9% +0.32%
=========================================
Files 127 130 +3
Lines 5705 5731 +26
Branches 762 763 +1
=========================================
+ Hits 5624 5668 +44
+ Misses 81 63 -18
Impacted Files | Coverage Δ | |
---|---|---|
packages/mdc-menu/foundation.js | 83.87% <0%> (-16.13%) |
:arrow_down: |
packages/mdc-list/index.js | 98.47% <0%> (-0.03%) |
:arrow_down: |
packages/mdc-textfield/helper-text/constants.js | 100% <0%> (ø) |
:arrow_up: |
packages/mdc-drawer/modal/foundation.js | 100% <0%> (ø) |
:arrow_up: |
packages/mdc-menu/index.js | 100% <0%> (ø) |
:arrow_up: |
packages/mdc-list/foundation.js | 100% <0%> (ø) |
:arrow_up: |
packages/mdc-textfield/constants.js | 100% <0%> (ø) |
:arrow_up: |
packages/mdc-textfield/character-counter/index.js | 100% <0%> (ø) |
|
...ages/mdc-textfield/character-counter/foundation.js | 100% <0%> (ø) |
|
...kages/mdc-textfield/character-counter/constants.js | 100% <0%> (ø) |
|
... and 14 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update eb8b8f6...9b033b8. Read the comment docs.
CLAs look good, thanks!
Hi, what's the hold-up here?
Hey there! We are hoping to be able to use this component soon. Any updates on when we'll get a review and release?
If this work is done, can the appropriate people handle the remaining tasks and push it through? The longer it sits, the more stale it gets.
Bump
I couldn't find the original branch used for this PR... how do we resolve the merge conflicts?
can we solve PR?