material-components-web icon indicating copy to clipboard operation
material-components-web copied to clipboard

Banner (incomplete)

Open lyubov-voloshko opened this issue 5 years ago • 9 comments

HTML and CSS for banner.

Is it OK or, please, point what should be corrected?

lyubov-voloshko avatar Feb 06 '19 09:02 lyubov-voloshko

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

googlebot avatar Feb 06 '19 09:02 googlebot

Codecov Report

Merging #4359 into master will increase coverage by 0.32%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4359      +/-   ##
=========================================
+ Coverage   98.58%   98.9%   +0.32%     
=========================================
  Files         127     130       +3     
  Lines        5705    5731      +26     
  Branches      762     763       +1     
=========================================
+ Hits         5624    5668      +44     
+ Misses         81      63      -18
Impacted Files Coverage Δ
packages/mdc-menu/foundation.js 83.87% <0%> (-16.13%) :arrow_down:
packages/mdc-list/index.js 98.47% <0%> (-0.03%) :arrow_down:
packages/mdc-textfield/helper-text/constants.js 100% <0%> (ø) :arrow_up:
packages/mdc-drawer/modal/foundation.js 100% <0%> (ø) :arrow_up:
packages/mdc-menu/index.js 100% <0%> (ø) :arrow_up:
packages/mdc-list/foundation.js 100% <0%> (ø) :arrow_up:
packages/mdc-textfield/constants.js 100% <0%> (ø) :arrow_up:
packages/mdc-textfield/character-counter/index.js 100% <0%> (ø)
...ages/mdc-textfield/character-counter/foundation.js 100% <0%> (ø)
...kages/mdc-textfield/character-counter/constants.js 100% <0%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb8b8f6...9b033b8. Read the comment docs.

codecov-io avatar Feb 06 '19 10:02 codecov-io

CLAs look good, thanks!

googlebot avatar Feb 06 '19 10:02 googlebot

Hi, what's the hold-up here?

lubo avatar Mar 21 '19 15:03 lubo

Hey there! We are hoping to be able to use this component soon. Any updates on when we'll get a review and release?

hjhart avatar Apr 11 '19 14:04 hjhart

If this work is done, can the appropriate people handle the remaining tasks and push it through? The longer it sits, the more stale it gets.

neotsn avatar Jan 04 '20 15:01 neotsn

Bump

SampsonCrowley avatar Apr 30 '20 03:04 SampsonCrowley

I couldn't find the original branch used for this PR... how do we resolve the merge conflicts?

dotteddice avatar Jun 17 '20 17:06 dotteddice

can we solve PR?

anlexN avatar Jul 10 '22 03:07 anlexN