material-components-web-react icon indicating copy to clipboard operation
material-components-web-react copied to clipboard

feat(snackbar): include dismiss icon and missing foundation method handleActionIconClick

Open mgr34 opened this issue 6 years ago • 7 comments

currently the snackbar is missing the ability to add an optional dismiss icon and the related foundation method handleActionIconClick.

Dismiss Icon Snackbars are intended to dismiss on their own after a few seconds, but a dedicated dismiss icon may be optionally included as well for accessibility purposes. ([0]


I will be moving next week and largely unavailable, but if this is still open I'll try to have something for either 0.14.0/0.15.0 (in case the roadmap is ever updated ;)

mgr34 avatar Jun 14 '19 15:06 mgr34

Great sounds good! Thanks for opening this issue. I think it will probably be waiting for you when you get back. Good luck on your move!

moog16 avatar Jun 17 '19 19:06 moog16

Hey, @mgr34 @moog16 Any plan for this feature in the upcoming release?

krishnaxv avatar Aug 05 '19 10:08 krishnaxv

@krishnaxv I do not currently have time to prioritize this at the moment. If someone else would like to implement this feature that would be great! Otherwise, I will try to come back to this when time allows.

mgr34 avatar Aug 07 '19 17:08 mgr34

Hello, I have submitted a pull request adding the dismiss button. Unfortunately I'm unable to regenerate screenshots to make travis get green, if any one can help me to figure out what I'm doing wrong, this will be highly appreciated. I post more infos on #react discord channel (tell me if you want me to explain this here) Thanks

emri99 avatar Sep 18 '19 13:09 emri99

Hey, @mgr34 @moog16, could you please point me the direction to achieve this PR ? Thanks ;)

emri99 avatar Sep 24 '19 20:09 emri99

hey @emri99, I opened the issue and have submitted PR's to this great project in the past, but I am not involved in this project otherwise. @moog16 has been responsive in the past, but I see the project hasn't had much activity lately. Perhaps hop on the discord and see whats happening? Your PR has sat for awhile.

Sorry I couldn't be of more help!

mgr34 avatar Sep 24 '19 20:09 mgr34

I did post a more detailed explanation on the discord channel a week ago, but I didn't get any response about this problem until now. I was on my way to bump subject before trying to get help here ;) Thanks for your quick response anyway ;)

emri99 avatar Sep 24 '19 20:09 emri99