material-components-ios icon indicating copy to clipboard operation
material-components-ios copied to clipboard

[Icons] components/private/Icons as AssetCatalogs instead of individual files

Open dmaclach opened this issue 6 years ago • 5 comments

We have found that reducing the number of files in a bundle improves build times and install times on simulators. Right now aside from localized files, png files are the majority of files in our bundle. We would like to reduce this down. One place we are seeing a number of png files is inside MaterialIcons_ic_*.bundles.

Can we change this over to being AssetCatalogs? This appears to be the direction that Apple wants us going with assets in general.

Related issue, the "pathFor_ic_*" methods are not AssetCatalog friendly, and don't appear to have much (if any) use given that you can get the images using the methods that return UIImage. Can we pull them from the interface so that people don't depend on them?


Internal data

dmaclach avatar May 09 '18 21:05 dmaclach

Closing this due to inactivity greater than 6 months. Please feel free to reopen if you believe it should be worked on in the near future.

romoore avatar Jul 30 '19 19:07 romoore

I still think this should be worked on.

dmaclach avatar Jul 31 '19 04:07 dmaclach

The internal issue b/117178971 is now closed. This issue is being closed as a result.

material-mirror avatar Jul 31 '19 04:07 material-mirror

Correcting the bot.

codeman7 avatar Jul 31 '19 04:07 codeman7

Icons don't work at all for me.

zakdances avatar Jul 31 '20 21:07 zakdances