material-components-android icon indicating copy to clipboard operation
material-components-android copied to clipboard

[Docs] Fix anchors

Open pubiqq opened this issue 1 year ago • 2 comments

pubiqq avatar Jan 23 '24 19:01 pubiqq

Were these anchors broken or are you just changing them to title case?

raajkumars avatar Jan 31 '24 20:01 raajkumars

They are still broken, try clicking on the "Design & API Documentation" link here, for example. Title/sentence case doesn't affect the functionality of the links, I changed it just to make the link names match the headers.

pubiqq avatar Jan 31 '24 20:01 pubiqq

I'm not sure adding an extra - will work either. It'd probably be best to change the & to be and so we have Design and API Documentation and the link can be #design-and-api-documentation

leticiarossi avatar May 08 '24 20:05 leticiarossi

I'm not sure adding an extra - will work either.

Well, you can compare the current version with the proposed one yourself. You don't think I just added hyphens to random places for no reason, right? 😂

Or I can just replace all the ampersands in the headings with "and", as you wish.

pubiqq avatar May 10 '24 18:05 pubiqq

Ah, I only tested internally where we have the docs and there the current link works and the new one doesn't, but on github I see now it's the opposite. Sometimes there are discrepancies like this with github so changing to Design and API Documentation would be the best option then to work on both places!

Side note - of course I didn't think you'd do a change for no reason, but misunderstandings and mistakes can happen from both sides. Let's cultivate a respectful environment here :)

leticiarossi avatar May 10 '24 20:05 leticiarossi

Ok, deal.

pubiqq avatar May 14 '24 22:05 pubiqq