material-components-android icon indicating copy to clipboard operation
material-components-android copied to clipboard

[Slider] `cut` label looks ridiculous

Open pubiqq opened this issue 2 years ago • 5 comments

Material Library version: 1.7.0-beta01

pubiqq avatar Aug 18 '22 22:08 pubiqq

Ah, agree. It looks very bad. To help us fix this better, what's the expected appearance of a "cut" label for slider in your case?

pekingme avatar Aug 18 '22 22:08 pekingme

To be honest, I don't like the current default "aerostat"-labels. I would most likely use regular rectangular labels with rounded/cut corners by default (almost like in previous Material, but with some tweaks):

Material 3 (rounded) Material 3 (rounded, tweaked)

pubiqq avatar Aug 19 '22 13:08 pubiqq

And here is an example with cut labels:

Material 3 (cut) Material 3 (cut, tweaked)

pubiqq avatar Aug 19 '22 13:08 pubiqq

Thanks for the screenshot. The label used in the tweaked version is M2 version. But will let our design know the concern.

pekingme avatar Aug 19 '22 16:08 pekingme

The label used in the tweaked version is M2 version.

As I mentioned before, it looks "almost like in previous Material":

M2 (cut) M3 (cut, tweaked)

And I think it's the best option as the default tooltip style among the presented.

M2 tooltips look incomplete, as if no styles have been applied to them at all. M3 tooltips look better, but they are more difficult to adapt to every shape, and even "default" rounded tooltips look too chubby-cheeked in some cases:

pubiqq avatar Aug 24 '22 14:08 pubiqq

As for cut corners - I think it just doesn't make sense to use a 50% corner radius with cut corners on tooltips - if a client want cut corners, they should set custom corner sizes to make it look reasonable as well. Not sure if we should fix catalog demo though - yes, it looks bad, but given that using cut corners is an app-wide setting, it feels a bit weird to me to have special logic in slider demo specifically to fix the cut corner issue.

As for the unsmooth round corner curves - I agree we should tune our edge treatment algorithm to make it look better but I'm afraid it can be a low priority to us.....

Let me backlog the issue for now. But a PR to fix the unsmooth curve problem will definitely be welcome.

drchen avatar Feb 24 '23 20:02 drchen