material-components-android
material-components-android copied to clipboard
[MaterialDatePicker] Add a optional 'Clear' button
Adds an optional 'Clear' button that be used to remove the user selected date as described in #1332
closes #1332
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!
and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
@googlebot I signed it!
I didn't see the change. Did you forget to commit?
I didn't see the change. Did you forget to commit?
Have not committed yet. Am toying with the implementation to experiment with different UXs
New changes are loaded though I think I made a mistake of force pushing rather than a new commit. Either way, this new implementation addressed the comments from @drchen and changes the implementation to allow for the clear button to optionally dismiss the dialog when clicked vs. just clearing the current selection.
New changes pushed based on @drchen feedback. All except last comment applied.
Thank you!
Hi there, sorry for the delay. Do you mind resolving the new conflicts so I can review and confirm with @drchen and submit.
@josefigueroa168 done as requested. Thank you.
Is there a possibility of this making it into 1.6?
I'm really hoping to be able to remove all the copied DatePicker code from my app
@DvTonder, thanks again for the PR. Could you try to squash all your commits into one? I have some difficulties to pull your PR into internal repo. I think the merge master commits causes some change mapping issues.
@pekingme I will see if I can figure it out.
Single commit squashed change pull request sitting at #2542
This obviates the need for this pull request
Thanks for working on this so quickly, @DvTonder. But it still doesn't work. When pulling a PR into Google internal repo, all the commits are considered as one change. The "merge master" creates a lot of conflicts. Could you rebase to the head instead of merging the master? Sorry for the inconvenience.
@pekingme I'm not sure how to do what you are asking. I'm thinking easiest will be to copy the changed files to disk somewhere, delete my repo / fork altogether, then re-fork from the source and re-add the changed files I saved copies of as a new commit on the new fork and do a pull request. Is that how to do it?
@DvTonder Thanks for trying. I'll do something similar on my end. Will delete the new PR you just created and associate the changes with this PR.
@pekingme I'm standing by if you want me to try as well. I can do so this evening.
@DvTonder I managed to pull it into the internal repo. During the internal review, we noticed that we need some feedback from design for full-screen use case. Stay tuned.
It's been 3 months since the last update on this. Any news?
Hi @DvTonder,
I confirmed with our designers. They are aware of the request and adding the clear button in the new design - yes they are working on a minor revamp of the date picker design. I'm sorry for the long wait - please stay tuned.
Good afternoon. This is my regular, 3 monthly, check-in on this topic.
I see many commits in recent weeks for Date and Time picker. Dare I hope that this feature is also in the backlog?
Hey guys, When can I see this "CLEAR" button from official release?