Nico Matentzoglu
Nico Matentzoglu
Its hard to do 2 on the fly.. We check these in Mondo after the fact, not at PR time. Addressing this issue in a computational way is currently not...
@cmungall can we use the owl-patterniser on Uberon? Would you be able to support @rays22 to do that (because we want to go that direction anyways not only for Uberon,...
@anitacaron mention in tech team? Documentation of this could be universally useful..
Mybe aplit the issue: 1. If the diff touches an intersections_of, require a cjm / davidos review (do this in github action) 2. The pattern based pattern based validation requires...
@gouttegd here is what I was thinking (roughly) https://github.com/obophenotype/test-actions/blob/main/.github/workflows/reviewers.yml However, the last block is bad from a workflow perspective. I would like to post a failing review, but I cant...
Thanks for feedback.. I forgot to change the grep goal, sorry. Better? https://github.com/obophenotype/test-actions/blob/main/.github/workflows/reviewers.yml I tested the diff.txt logic locally now, but weirdly the condition seems not to work in the...
Works now. If you check one last time, I will make a PR on Uberon with the action for further discussion!
Draft here: https://github.com/obophenotype/uberon/pull/3425
The added level of generality would come at additional processing cost; right now the action virtually needs no memory, finishes in 15 seconds doesn't need ODK - I would first...
We have completed this in https://github.com/obophenotype/uberon/pull/3425