Nico Matentzoglu

Results 2725 comments of Nico Matentzoglu

@hrshdhgd I assigned this to you for review. I think it is done, but I am a bit scared of how the changes will impact people relying on validation downstream,...

@hrshdhgd just to be sure I need a positive approval from you for this PR, and real certainty that all is understood and correct. Can you comment on the exact...

> So the idea here is if validation encounters a SSSOM tsv file does not contain (say) a valid column value, the row is dropped and warning is logged. Correct?...

100%! As all we do, iterate :)

I have tested this now (complete release) and it works fine. Maybe test it again - I leave it to you to merge when you think the time is right.

> @matentzn do these changes warrant a mock Mondo release or did you also do that check? I did do a full release; but maybe its not a terrible idea...

> Ah, sorry I missed that earlier that you mentioned you did a full release. For testing code that might break or cause issues with the release, Sabrina has been...

Dropping this as we determined we want the evidence for the redundant axioms

> Sounds great, this is what https://github.com/linkml/prefixmaps intended to do I think they can exist side by side, as the coverage of prefixmaps is a little less than the entirety...