matejcik

Results 300 comments of matejcik

we'll also need some tests that validate `expected_responses` for the old and the new flow

> In the messages related to payment requests I changed the required fields to optional with default values. In principle they are all required, but this allows them to be...

I can reproduce the problem locally. It seems that when using `-t trezor` but not `-d `, hwi tries to enumerate devices. This tries to query the Trezor for its...

full stack trace at the stuck point is helpful: ``` Traceback (most recent call last): File "/home/matejcik/.cache/pypoetry/virtualenvs/hwi-zW7m4qgq-py3.10/bin/hwi", line 6, in sys.exit(main()) File "/home/matejcik/projekty/prace/HWI/hwilib/_cli.py", line 304, in main result = process_commands(sys.argv[1:])...

> Also they may go from Basic to Advanced. can't because then they don't hit the if-condition. the logic is not entirely correct but per the comment "upgrade Single to...

yeah I was thinking of adding a sound effect .) but a visual indication would be good too

> * hash processor syscalls - again, maybe we shouldn't expose raw sha256 syscalls, which are needed for firmware header info in coreapp, but perhaps introduce the firmware header info...

> any feedback on this PR? sure! in general, we are interested in taproot multisig functionality. we don't have it on the roadmap at the moment, so before anything happens...

> enforcing the presence of return type annotations will do little or nothing to improve the type safety of your code when you're using pyright. weirdly specific counter-example: ``` async...

perhaps this should be deferred until #617 ? OTOH this seems to only affect GetAddress, in which case maybe that's not necessary?