Matej Gera

Results 117 comments of Matej Gera

Looks like there is a PR open from @tend2infinity here https://github.com/thanos-io/thanos/pull/5182 that still needs a bit of attention, maybe you could join force in finishing it?

I looked a bit through the original report and I'm wondering whether there are two distinct things going on: 1) we're seeing the out-of-bounds error on local node 2) when...

I see, so it seemingly happens at random times. So it seems a receiver replica simply fails to forward the request to another receiver(s) and this is manifesting itself as...

@Harshitavkb26 How's it looking? Were you able to check the comments? :upside_down_face:

I was mainly following up some changes we had upstream in Thanos (https://github.com/thanos-io/thanos/pull/5508) to validate labels, seeing now that labels are also somewhat being validated in TSDB before ingestion (what...

@roidelapluie that is true for scraping, but referring back to my original question, this might not be true for series coming over remote write. So even though it is a...

> @matej-g would you mind rebasing this PR? I'd like to do another review. Phew, done, thanks for taking a look! :slightly_smiling_face:

Hey @fpetkovski @bwplotka, Thanks for the reviews, I addressed all of the comments, except for using lazy retrieval strategy in proxy, since it seem to be causing receiver to panic....

I'll wait on https://github.com/thanos-io/thanos/pull/5717 and switch the eval strategy, I believe then this is finally good to go :+1:

Sorry for the delay, PR is now updated, this should be good to go once CI passes