Snacky icon indicating copy to clipboard operation
Snacky copied to clipboard

Proguard is weak

Open Wahyd opened this issue 5 years ago • 4 comments

Hi,

I see in consumer-proguard-rules.pro these lines.:

-keep public class * { public protected *; }

if we include this library in a multi module project, Proguard keep ALL classes, even those are not in this library. (Indeed Android Studio Plugin append all Proguard files)

Wahyd avatar Feb 13 '19 15:02 Wahyd

What is the right way to keep the public classes of this lib? should i instead use

-keep public class de.mateware.snacky.* {
    public protected *;
}

matecode avatar Mar 01 '19 15:03 matecode

What is the right way to keep the public classes of this lib? should i instead use

-keep public class de.mateware.snacky.* {
    public protected *;
}

This seems much better, because it'll only affect the library code and not the entire project in which it is used. With the current configuration I can't correctly obfuscate a project in which I'm using Snacky. This fix would be very much appreciated.

SebastianIRodriguez avatar Feb 24 '20 20:02 SebastianIRodriguez

Is the Proguard issue fixed in current version?

amarilindra avatar Apr 09 '20 14:04 amarilindra

changed the consumer proguard file, hope everything is fine now ... looking for feedback

matecode avatar Apr 09 '20 22:04 matecode